Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the validation of incoming redirect_uri once the webauth flow resumes back #850

Merged

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented May 6, 2024

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  • Removed the validation of incoming redirect_uri once the webauth flow resumes back because:

    • Validation of incoming redirect_uri is no longer needed when the WebAuth is performed via PKCE flow and WebAuth is performed via PKCE in all possible scenarios within Auth0.swift
    • Additionally, successful redirection of execution back to the app once the transaction is resumed is also a justifier that the redirect_uri is valid.

📎 References

auth0/Auth0.swift/pull/838

🎯 Testing

@desusai7 desusai7 self-assigned this May 6, 2024
@desusai7 desusai7 marked this pull request as ready for review May 6, 2024 11:28
@desusai7 desusai7 requested a review from a team as a code owner May 6, 2024 11:28
Widcket
Widcket previously approved these changes May 6, 2024
@desusai7 desusai7 merged commit c0f37e0 into master May 8, 2024
9 checks passed
@desusai7 desusai7 deleted the SDK-4782-remove_validation_of_incoming-redirect_uri branch May 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants